Run conformance tests #2542
Merged
Run conformance tests #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
lann
reviewed
Jun 13, 2024
tests/conformance-tests/src/main.rs
Outdated
Comment on lines
11
to
21
| let env_config = SpinCli::config( | ||
| spin_binary.clone(), | ||
| [], | ||
| move |e| { | ||
| e.copy_into(&test.manifest, "spin.toml")?; | ||
| e.copy_into(&test.component, test.component.file_name().unwrap())?; | ||
| Ok(()) | ||
| }, | ||
| test_environment::services::ServicesConfig::none(), | ||
| testing_framework::runtimes::SpinAppType::Http, | ||
| ); |
There was a problem hiding this comment.
Maybe its just because I'm looking at this without the help of a IDE, but its a bit hard to understand what some of these args mean ([], the closure). Could/should this be a struct?
There was a problem hiding this comment.
I've refactored the [] into a struct along wiht the spin_binary and SpinAppType since all of these have to do with how Spin is run. Giving a name to the closure has a less clear solution but hopefully with less args that's less of a problem 🤷 ?
| services_config, | ||
| create_runtime: Box::new(move |env| { | ||
| preboot(env)?; | ||
| SpinCli::start(&spin_binary, env, spin_up_args, app_type) |
kate-goldenring
approved these changes
Jun 13, 2024
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started creating a conformance testing suite in https://github.com/fermyon/conformance-tests. You can read more about the aim of the project in the README of the repo. In short, we are trying to create a set of tests that all Spin compliant runtimes are expected to pass.
We're currently not running these yet in CI, but that will come soon in a follow up.
cc @kate-goldenring for visibility