Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task Wait for DNS entries to propagate not stable #57

Closed
mr-ssd opened this issue Jun 16, 2023 · 6 comments · Fixed by #62
Closed

Task Wait for DNS entries to propagate not stable #57

mr-ssd opened this issue Jun 16, 2023 · 6 comments · Fixed by #62

Comments

@mr-ssd
Copy link
Contributor

mr-ssd commented Jun 16, 2023

The task named "Wait for DNS entries to propagate" in role acme_certificate is not stable when using with Route53.

I suggest we should change wait: false to wait: true to wait until the changes have been replicated to all Amazon Route 53 DNS servers before we check for the TXT record.

@felixfontein
Copy link
Owner

Using wait: true is not a good solution either, since that makes the role incredibly slow when using Route53.

@mr-ssd
Copy link
Contributor Author

mr-ssd commented Jun 19, 2023

Can we change it as an option in a variable?

@felixfontein
Copy link
Owner

I would prefer not to add a config for that. I started some work in the aws collections to make it possible to solve this in a cleaner way: ansible-collections/amazon.aws#1683 ansible-collections/community.aws#1904

@mr-ssd
Copy link
Contributor Author

mr-ssd commented Aug 2, 2023

@felixfontein thank you for the update. Should this case be closed?

@felixfontein
Copy link
Owner

I would keep this issue open, as the problem hasn't been resolved yet.

@felixfontein
Copy link
Owner

ansible-collections/community.aws#1904 together with #62 fixes this, and is pretty efficient as well. I tested it this morning with a larger set of certificates (many of them with Route 53 DNS validation), and it worked as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants