Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused variables in differential photometry #220

Closed
1 task
mwcraig opened this issue Dec 19, 2023 · 0 comments
Closed
1 task

Fix unused variables in differential photometry #220

mwcraig opened this issue Dec 19, 2023 · 0 comments
Assignees
Labels
linting refactor Summer 2023 project to rewrite stellarphot

Comments

@mwcraig
Copy link
Contributor

mwcraig commented Dec 19, 2023

For all of these issues, first delete the appropriate line in pyproject.toml that excludes the subpackage from checks. for differential_photometry you would delete this line:

"stellarphot/differential_photometry/*" = ["F"]

After that, run ruff either with tox -e lint or ruff .. The errors you get should be the ones -- fix them! If it is an unused function argument make sure to search the project for calls to that function to update the arguments there too.

  • stellarphot/differential_photometry/tests/test_aij_rel_fluxes.py:75:5: F841 Local variable photom is assigned to but never used
@mwcraig mwcraig added refactor Summer 2023 project to rewrite stellarphot linting labels Dec 19, 2023
@mwcraig mwcraig self-assigned this Jan 4, 2024
@mwcraig mwcraig closed this as completed in 417db6a Jan 4, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in stellarphot refactoring Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linting refactor Summer 2023 project to rewrite stellarphot
Projects
Status: Done
Development

No branches or pull requests

1 participant