Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Generate sequelize model according to sequelize 4.0 #216

Merged
merged 1 commit into from
Jun 10, 2017
Merged

Generate sequelize model according to sequelize 4.0 #216

merged 1 commit into from
Jun 10, 2017

Conversation

jsphpl
Copy link
Contributor

@jsphpl jsphpl commented Jun 9, 2017

classMethods is deprecated as of 4.0.0
See http://docs.sequelizejs.com/manual/tutorial/upgrade-to-v4.html

@daffl daffl merged commit b12ef33 into feathersjs-ecosystem:master Jun 10, 2017
@jsphpl
Copy link
Contributor Author

jsphpl commented Jun 12, 2017

I am right now not really sure how the 4.0.0 finds its way into a new feathers project. According to feathersjs-ecosystem/feathers-sequelize#123, feathers-sequelize hasn't adopted 4.0 yet, correct?

In the package.json of feathers-sequelize, ^3.25.0 is required (don't know why in devDependencies, either).

Should this PR have been merged at all, already?

@daffl
Copy link
Member

daffl commented Jun 12, 2017

Yes. It's just a devDependency and for the tests, the adapter will let you use whichever Sequelize version you install and provide (the latest official which is 4.1.0 according to npm).

@jsphpl
Copy link
Contributor Author

jsphpl commented Jun 12, 2017

@daffl thanks for the clarification. So the version to install is chosen by the CLI?
Edit: …when issuing feathers generate app

@daffl
Copy link
Member

daffl commented Jun 12, 2017

Well it's really chosen by npm, whatever is the latest version. Reminded me of adding the ORMs to the generator-feathers repo though so that the tests are run when they are updated (#219).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants