This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Generator refactoring2 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekryski
commented
Feb 7, 2017
| @@ -51,7 +51,7 @@ describe('generator-feathers', function() { | |||
| }); | |||
| } | |||
|
|
|||
| before(() => helpers.run(path.join(__dirname, '..', 'generators', 'app')) | |||
| beforeEach(() => helpers.run(path.join(__dirname, '..', 'generators', 'app')) | |||
There was a problem hiding this comment.
I needed to switch this to beforeEach. For some reason when running the tests using the same app and same directory some config values aren't being cleaned up properly. Potentially this is due to it being headless but I went and verified manually that you can generate multiple services with different dbs and different adapters on the same app. It even works if you say, used mongodb and then decided to switch to mongoose.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: