Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Scope not generated for Auth0 strategy #364

Closed
akagomez opened this issue Jun 13, 2018 · 1 comment
Closed

Scope not generated for Auth0 strategy #364

akagomez opened this issue Jun 13, 2018 · 1 comment

Comments

@akagomez
Copy link

It isn't stated in the auth0/passport-auth0 documentation, but the Auth0 strategy will not return any useful profile data unless you provide a scope. See: https://auth0.com/docs/scopes/current#standard-claims.

Currently the generator only adds a domain to the Auth0 config:

https://github.com/feathersjs/generator-feathers/blob/15aa20fa73c9e07e167b68c26b72ff119da1364a/generators/authentication/index.js#L109

However, we probably want to also include a scope in the same way we do for the Google and Facebook strategies.

@daffl
Copy link
Member

daffl commented Jun 14, 2018

I think it definitely makes sense to at least add profile just like for the other strategies. We're not running any oAuth tests so a pull request should be fairly straightforward by just adding those lines.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants