This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Typo: "typ" should be "type" #322

Closed

morphatic opened this issue Dec 19, 2017 · 5 comments

Contributor

morphatic commented Dec 19, 2017

https://github.com/feathersjs/generator-feathers/blob/fa2c712b534d338d16c225b0ce3127c3cede6c03/generators/authentication/index.js#L79

Member

daffl commented Dec 19, 2017

This is correct. See the JWT spec.

daffl closed this as completed

Contributor Author

morphatic commented Dec 19, 2017

Oh. Then it's wrong here: https://docs.feathersjs.com/guides/auth/recipe.oauth-basic.html

I noticed the difference between the two and just assumed (incorrectly) that the weirdly-spelled one was wrong. :)

Member

daffl commented Dec 19, 2017

Ah, good catch, can you submit a PR that fixes it (and maybe check if there is any other references like that)?

Contributor Author

morphatic commented Dec 19, 2017 •

edited

Loading

submitted #956

Member

daffl commented Dec 19, 2017

Fixed via feathersjs-ecosystem/docs#956

daffl reopened this

daffl closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.