Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Rethink db option is 'database' instead of 'db' and db config gets overwritten #181

Closed
genyded opened this issue Mar 1, 2017 · 2 comments

Comments

@genyded
Copy link

genyded commented Mar 1, 2017

Not sure if this is the place for issues against the new generators, but I asked in slack and this was the link given. Anyway, the new generators create the rethink config with a database option and it should be db:

"rethinkdb": {
    "database": "test", /*** <- this should be `db` not `database` ***/
    "servers": [
      {
        "host": "localhost",
        "port": "28015"
      }
    ]
  }

Also if you create a new service with an alternate config (connection string), the existing rethink db config gets overwritten. Service creation should not overwrite driver config. Maybe not even prompt for config for services and default them to the driver config. They can be altered after being created.

@daffl
Copy link
Member

daffl commented Mar 1, 2017

This is already fixed in the latest version (see https://github.com/feathersjs/generator-feathers/blob/master/generators/connection/index.js#L55). Make sure npm ls generator-feathers -g shows version 1.0.0-pre.5

@genyded
Copy link
Author

genyded commented Mar 1, 2017

Verified fixed in pre.5.

@genyded genyded closed this as completed Mar 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants