Fix es6 build and add Steal compatibility.

[marshallswain]

@daffl

I've fixed the exports on src/sockets/index.js so that the Babel build does not strip socketio and primus from the final export. This line in client.js

Object.assign(client, rest, sockets);

was getting compiled to

_extends(client, _index2.default, _index4.default);

But _index4.default was undefined. Modifying the exports fixed the issue.

I've also added the events and querystring core node modules to the dependencies, so they get included with the build. This lets Steal use the main package instead of the dist/feathers.js file.

Finally, I've added /index to a couple of imports because Steal was looking for a file called ./rest.js instead of ./rest/index. The same goes for ./sockets.

Closes #12 .

[daffl]

Those are good fixes although you could just map feathers-client to dist/feathers-client for Steal. That should include everything (the Browserified events etc.).

I'm still not happy how Steal doesn't ship with the Node built-ins by default (I think that is what https://github.com/stealjs/node-browser-builtins is supposed to be for). Everything else in this PR is fine but it would be nice to get rid of the events and querystring shim packages.

[marshallswain]

Yeah. It doesn't seem very intuitive to have to install modules that are pre-packaged with Node. Isn't there an EngineDependencies or something like that for Steal? Could the browser be one of those engines to have it install those specific dependencies for Steal?

[daffl]

I would take the dependencies out here and try it with https://github.com/stealjs/node-browser-builtins or mapping to dist/. The other changes are fine but I don't think we should start adding dependencies or special configuration for every module loader (their whole point is to work transparently imho).

[marshallswain]

Ok. All good points. Take a look, now.

The dist/ build will probably work with Steal with these changes. I think it was only not working earlier because of the exports issue causing feathers.socketio to be missing. I should be able to just do

import feathers from 'feathers-client/dist/feathers';

[marshallswain]

@daffl You mind if I merge and release this?

[daffl]

I had issues with the add-module-exports plugin not setting module.exports if there was another export in the module. Can you double check if it does? I actually added a test for it to the plugin generator:

it('is CommonJS compatible', () => {
  assert.equal(typeof require('../lib'), 'function');
});

And changed the npm test script to:

"test": "npm run compile && npm run jshint && npm run mocha"

[daffl]

This probably needs to be 'object' ;)