Skip to content
This repository has been archived by the owner on Sep 4, 2019. It is now read-only.

Authentication should be removed #136

Closed
elfey opened this issue Jan 25, 2017 · 3 comments
Closed

Authentication should be removed #136

elfey opened this issue Jan 25, 2017 · 3 comments

Comments

@elfey
Copy link

elfey commented Jan 25, 2017

With the new feathers-authentication-client, authentication isn't really necessary in this module. This module is now, for the most part, kind of a "networking" module for connecting the client to the server (as opposed to authenticating).

So it would make sense that we remove the authentication bit from this module. (i.e. feathersClient.authentication because it's being replaced with feathers-authentication-client).

@marshallswain
Copy link
Member

@mz103 the intention of this module was originally to provide all client modules in one place. All other modules would be at feathers-module/client.

@daffl
Copy link
Member

daffl commented Feb 7, 2017

I think we will keep it like this for now (feathers-authentication-client will still be feathers.authentication). It will all make more sense in the next version when we tackle #137. I still don't know how I feel about browser builds for each individual client module but maybe that is the best way to do it to avoid any more confusion on what is included in the client build.

@marshallswain
Copy link
Member

Closing this for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants