From 642c96b393b94346b00aaafd0e8acb24a7eb4eb5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Germ=C3=A1n=20Mart=C3=ADnez?= Date: Wed, 24 Aug 2022 19:48:52 +0200 Subject: [PATCH] Make signTransaction method immutable --- packages/safe-core-sdk/src/Safe.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/safe-core-sdk/src/Safe.ts b/packages/safe-core-sdk/src/Safe.ts index 4605a700c..f4a849035 100644 --- a/packages/safe-core-sdk/src/Safe.ts +++ b/packages/safe-core-sdk/src/Safe.ts @@ -395,11 +395,10 @@ class Safe { }) signedSafeTransaction.addSignature(signature) - // TO-DO: Remove in v3.0.0 { + // TO-DO: Remove in v4.0.0 { console.warn( - `⚠️ the "signTransaction" method now returns a signed Safe transaction. Please update your code according to the new documentation: https://github.com/safe-global/safe-core-sdk/tree/main/packages/safe-core-sdk#signtransaction. In >=v3.0.0, the signature will be added only to the return transaction object, and not to the one passed as an argument.` + `⚠️ the "signTransaction" method now returns a signed Safe transaction without modifying the passed safeTransaction argument. Please check the new documentation: https://github.com/safe-global/safe-core-sdk/tree/main/packages/safe-core-sdk#signtransaction.` ) - safeTransaction.addSignature(signature) // } return signedSafeTransaction