Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail with meaningful error in case an unsupported trigger is used #498

Closed
2 tasks done
simoneb opened this issue Oct 9, 2023 · 1 comment
Closed
2 tasks done

Comments

@simoneb
Copy link
Collaborator

simoneb commented Oct 9, 2023

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

Although the documentation shows code examples using pull_request as a trigger, we have received several reports over time of people trying to use this action with other targets, such as pull_request_target. The motivations are described in #355.

To avoid further reports, we should fail with a meaningful error message when an unexpected trigger is used.

Motivation

No response

Example

No response

@simoneb
Copy link
Collaborator Author

simoneb commented Jan 8, 2024

I'm closing this as there is no consensus about what we should do with this conversation.

@simoneb simoneb closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant