Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark suggestion: deepcopy #379

Closed
eendebakpt opened this issue May 12, 2022 · 7 comments
Closed

Benchmark suggestion: deepcopy #379

eendebakpt opened this issue May 12, 2022 · 7 comments

Comments

@eendebakpt
Copy link

At the python language summit @markshannon invited ideas for benchmarking. One python method that is currently not in the pyperformance benchmarks is deepcopy (at least not in the benchmarks that execute on my system).

In #91610 (reimplement deepcopy in C) there is a simple benchmarking script for deepcopy. It is a simple execution of deepcopy on a dict and a dataclass. The benchmark is really simple (not a program), but in larger projects the cost of deepcopy was sometimes a significant part of the total execution time.

@ericsnowcurrently
Copy link
Collaborator

Would you mind opening an issue on pyperformance?

@eendebakpt
Copy link
Author

Opened an issue at pyperformance: pyperformance #199

@AlexWaygood
Copy link

AlexWaygood commented May 13, 2022

Would you mind opening an issue on pyperformance?

Ah, should I update my blog post on Mark's talk? I believe at the moment I have a sentence in there inviting people to open issues here if they have benchmarking suggestions, but maybe pyperformance would be better?

@ericsnowcurrently
Copy link
Collaborator

Would you mind opening an issue on pyperformance?

Ah, should I update my blog post on Mark's talk? I believe at the moment I have a sentence in there inviting people to open issues here if they have benchmarking suggestions, but maybe pyperformance would be better?

Good catch! It would probably be better to point them to the pyperformance tracker. Perhaps @markshannon has a good reason for opening the issues here? Otherwise, pyperformance would be better.

@AlexWaygood
Copy link

Perhaps @markshannon has a good reason for opening the issues here? Otherwise, pyperformance would be better.

I've just listened back to the recording of the talk, and I don't think Mark actually specified which issue tracker would be best to suggest new benchmarks (he just said "please give us benchmark suggestions"), so I think this is entirely on me :)

I'll go ahead and update my article.

@AlexWaygood
Copy link

@ericsnowcurrently
Copy link
Collaborator

You're the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants