Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a decorator like @repeat_at? #184

Open
triptec opened this issue Mar 25, 2021 · 4 comments · May be fixed by #219
Open

Add a decorator like @repeat_at? #184

triptec opened this issue Mar 25, 2021 · 4 comments · May be fixed by #219
Labels
question Further information is requested

Comments

@triptec
Copy link

triptec commented Mar 25, 2021 •
edited
Loading

Hi!
I find myself wanting a decorator like @repeat_at(cron="0 0 13 * * *") to run the task at 1 pm every day, if I where to implement something like that would you consider merging it to this repo?

probably using croniter for the parsing and just getting the numbers of seconds to sleep and just using the same logic as repeat_every
@triptec triptec added the question Further information is requested label Mar 25, 2021
@moraesjeremias
Copy link

moraesjeremias commented Apr 8, 2021 •
edited
Loading

@triptec excellent point!
Do you mind to implement in a schedule every().[dayOfWeek].at(hour) like?

@triptec
Copy link
Author

triptec commented Apr 8, 2021

I wouldn’t know how to do that I’m afraid. What’s the upside of doing it that way?

@jykae jykae linked a pull request May 11, 2021 that will close this issue
Open
@jykae
Copy link

jykae commented May 11, 2021

hi @triptec 👋

Liked your idea, this was really helpful decorator for us & decided to contribute for project.

@triptec
Copy link
Author

triptec commented May 19, 2021

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: repeat_at decorator jykae/fastapi-utils
3 participants
@triptec @jykae @moraesjeremias