enable meta.delegates to enforce KEYWORD_ONLY for kwargs from #459
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Many thanks for the PR. I've made one suggested change (but haven't tested it -- so take a look and see if it works for you!).
You've accidentally added the whole _docs directory to your PR. Could you please remove it? I've just updated .gitignore so that this shouldn't happen again in the future.
fastcore/meta.py
Outdated
| @@ -120,20 +120,21 @@ def _f(f): | |||
| k = sigd.pop('kwargs') | |||
| s2 = {k:v for k,v in inspect.signature(to_f).parameters.items() | |||
There was a problem hiding this comment.
| s2 = {k:v for k,v in inspect.signature(to_f).parameters.items() | |
| s2 = {k:v.replace(kind=inspect.Parameter.KEYWORD_ONLY) for k,v in inspect.signature(to_f).parameters.items() |
If you made this change, would that mean you could then remove the line you added?
There was a problem hiding this comment.
Yes, this change works and my added line can be removed. Thanks Jeremy!
There was a problem hiding this comment.
Great. Just reply here when you've removed the _docs folder and we should be ready to go!
|
I have reverted my first troublesome commit and then only run |
|
Good job! |
|
Thank you Jeremy! This is my first contribution to fastcore, Wow! |
The details of this PR can be found in this forum thread.