Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make docments handle delegates #418

Merged
merged 1 commit into from
Jun 16, 2022
Merged

make docments handle delegates #418

merged 1 commit into from
Jun 16, 2022

Conversation

hamelsmu
Copy link
Contributor

@hamelsmu hamelsmu commented Jun 16, 2022

This moves the code that handles @delegates in docments outside nbdev into fastcore

This ports @muellerzr 's code to fastcore in large part, with small refactors.

nbdev is patched to be compatible with this change in AnswerDotAI/nbdev@cf2aa01

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hamelsmu hamelsmu closed this Jun 16, 2022
@hamelsmu hamelsmu reopened this Jun 16, 2022
@hamelsmu hamelsmu added the enhancement New feature or request label Jun 16, 2022
@hamelsmu hamelsmu merged commit 4f8e825 into master Jun 16, 2022
@jph00 jph00 deleted the delegates-in-docments branch July 25, 2022 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant