Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Custom connect button is throwing an error Cannot read properties of undefined (reading 'name') on v1.5.x #294

Closed
lykalabrada opened this issue Aug 22, 2023 · 3 comments · Fixed by #295
Labels
bug Something isn't working

Comments

@lykalabrada
Copy link

Describe the bug
Trying to bump our app's connectkit version from 1.4.0 to 1.5.1, but getting an error with the custom connect button

To reproduce
Simple codesandbox with custom connect button:
https://codesandbox.io/s/custom-connect-button-1-5-1-r69w5z

Expected behavior
Clicking of Connect Button is expected to work.

Screenshots
image

Environment details
Version 116.0.5845.96 (Official Build) (arm64)

Additional context

Add any other context about the problem here.

@lykalabrada lykalabrada added the bug Something isn't working label Aug 22, 2023
@lochie
Copy link
Member

lochie commented Aug 22, 2023

Looks like your missing the viem dependency in this example. I added "viem": "1.6.0", to the package.json and it seems to fix it. Let me know if that fixes your project

@lykalabrada
Copy link
Author

I added viem to the example but getting the same error. In our app we already have "viem" : "1.6.x" installed, but still having this issue

@lochie
Copy link
Member

lochie commented Aug 22, 2023

Looks like there's a missing check when InjectedConnector isn't found. Have created a PR to fix this. If you include the InjectedConnector in your config's connectors array it will fix this for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants