-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rules tags key is plural #1025
fix: rules tags key is plural #1025
Conversation
Catch up to Falco v0.19.0
@vicenteherrera: Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @vicenteherrera! It looks like this is your first PR to falcosecurity/falco 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Vicente, thanks for sending this but unfortunately the diff is empty ...
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added missing commit. But I created the PR from my |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vicenteherrera thanks for catching this 😃
Could you please remove the merge commit and sign-off your only commit?
@vicenteherrera can you please sign you commits ? with |
Catch up to Falco v0.19.0
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
Some falco rules use the keyword "tag" instead of "tags", which is the valid one (see diff).
Which issue(s) this PR fixes:
No error message is shown on rule load, but if you try to enable or disable rules using command line switches, it wil fail to do so for those rules.
Special notes for your reviewer:
First PR, have read procedures, but may still be doing something wrong. Will try to continue sending PRs in future, so I'm willing to learn the best way to do it.
Does this PR introduce a user-facing change?: