Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rules tags key is plural #1025

Closed

Conversation

vicenteherrera
Copy link
Contributor

Catch up to Falco v0.19.0

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:

Some falco rules use the keyword "tag" instead of "tags", which is the valid one (see diff).

Which issue(s) this PR fixes:

No error message is shown on rule load, but if you try to enable or disable rules using command line switches, it wil fail to do so for those rules.

Special notes for your reviewer:

First PR, have read procedures, but may still be doing something wrong. Will try to continue sending PRs in future, so I'm willing to learn the best way to do it.

Does this PR introduce a user-facing change?:

Fix: Some rules tags were not specified correctly.

Catch up to Falco v0.19.0
@poiana
Copy link
Contributor

poiana commented Jan 27, 2020

@vicenteherrera: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link
Contributor

poiana commented Jan 27, 2020

Welcome @vicenteherrera! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/XS label Jan 27, 2020
@leodido leodido self-requested a review January 27, 2020 13:52
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Vicente, thanks for sending this but unfortunately the diff is empty ...

@poiana
Copy link
Contributor

poiana commented Jan 27, 2020

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@poiana
Copy link
Contributor

poiana commented Jan 27, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign leodido
You can assign the PR to them by writing /assign @leodido in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vicenteherrera
Copy link
Contributor Author

Added missing commit. But I created the PR from my fix/tags_singlar branch, and per comments I understand I have to do it from same dev branch after rebase. Confirm and we can cancel this PR to open a new one. Sorry for the inconvenience.

@leodido leodido changed the base branch from dev to master February 3, 2020 15:13
@leodido leodido self-requested a review February 4, 2020 14:50
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vicenteherrera thanks for catching this 😃

Could you please remove the merge commit and sign-off your only commit?

@leodido leodido changed the title Merge pull request #1 from falcosecurity/dev fix: rules tags key is plural Feb 4, 2020
@Kaizhe
Copy link
Contributor

Kaizhe commented Feb 4, 2020

@vicenteherrera can you please sign you commits ? with -s in your commits.

@vicenteherrera vicenteherrera deleted the fix/tags-singular branch March 9, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants