Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese Lorem sentences look unnatural #1917

Closed
rastamhadi opened this issue Jan 23, 2020 · 1 comment
Closed

Japanese Lorem sentences look unnatural #1917

rastamhadi opened this issue Jan 23, 2020 · 1 comment

Comments

@rastamhadi
Copy link
Contributor

Describe the bug

In the Japanese locale, Faker::Lorem.sentence, Faker::Lorem.sentences, Faker::Lorem.paragraph and Faker::Lorem.paragraphs produce strings with:

  1. Spaces in between words
  2. Spaces in between sentences

Natural Japanese text includes neither of these spaces.

e.g. https://ja.wikipedia.org/wiki/%E3%83%86%E3%82%B9%E3%83%88%E3%83%87%E3%83%BC%E3%82%BF

image

To Reproduce

irb(main):001:0> I18n.locale = :ja
=> :ja
irb(main):002:0> Faker::Lorem.paragraph
=> "いう 日没 電話。 がいよう 当て字 シアトルし。 フランス人 あくれい 弱虫。"

Expected behavior

Japanese sentences without spaces.

irb(main):002:0> Faker::Lorem.paragraph
=> "いう日没電話。がいよう当て字シアトルし。フランス人あくれい弱虫。"
@rastamhadi
Copy link
Contributor Author

Solved in #1918, so I'm going to go ahead and close this. Thank you @koic @vbrazo @Zeragamba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant