Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization for NL is not valid for postalCodes #3368

Open
9 of 10 tasks
MDSLKTR opened this issue Jan 9, 2025 · 1 comment
Open
9 of 10 tasks

Localization for NL is not valid for postalCodes #3368

MDSLKTR opened this issue Jan 9, 2025 · 1 comment
Labels
c: bug Something isn't working m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone

Comments

@MDSLKTR
Copy link

MDSLKTR commented Jan 9, 2025

Pre-Checks

Describe the bug

According to the postalCode patterns for the netherlands the following example is allowed in https://github.com/faker-js/faker/blob/v8/src/locales/nl/location/postcode.ts:

1### SS
...
9### SS

same for SA/SD

This is not allowed according to:

https://en.wikipedia.org/wiki/Postal_codes_in_the_Netherlands#:~:text=The%20letter%20combinations%20'SS'%2C,Nazi%20occupation%20of%20the%20Netherlands.&text=The%20first%20two%20digits%20indicate,usually%20on%20the%20same%20street.

Minimal reproduction code

import { fakerNL as faker } from '@faker-js/faker';

console.log(faker.location.zipCode()); // until you hit any of the combos

Additional Context

No response

Environment Info

Faker 8.4.1

Which module system do you use?

  • CJS
  • ESM

Used Package Manager

yarn

@MDSLKTR MDSLKTR added c: bug Something isn't working s: pending triage Pending Triage labels Jan 9, 2025
@MDSLKTR MDSLKTR changed the title Localization for NL is valid for postalCodes Localization for NL is not valid for postalCodes Jan 9, 2025
@matthewmayer
Copy link
Contributor

Likely requires #3233 to be implemented first.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent m: location Something is referring to the location module s: accepted Accepted feature / Confirmed bug and removed s: pending triage Pending Triage labels Jan 9, 2025
@ST-DDT ST-DDT added this to the vAnytime milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

No branches or pull requests

3 participants