Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(image): improve urlPlaceholder alternatives #3351

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Dec 29, 2024

Explicitly lists dataUri as alternative for the deprecated urlPlaceholder.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent m: image Something is referring to the image module labels Dec 29, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Dec 29, 2024
@ST-DDT ST-DDT requested review from a team December 29, 2024 16:14
@ST-DDT ST-DDT self-assigned this Dec 29, 2024
Copy link

netlify bot commented Dec 29, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit b386d31
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6771756a1fda1600084aed8e
😎 Deploy Preview https://deploy-preview-3351.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (637f81b) to head (b386d31).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3351      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files        2811     2811              
  Lines      217023   217023              
  Branches      942      941       -1     
==========================================
- Hits       216972   216966       -6     
- Misses         51       57       +6     
Files with missing lines Coverage Δ
src/modules/image/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT merged commit 39f76f7 into next Dec 29, 2024
28 checks passed
@ST-DDT ST-DDT deleted the docs/image/urlPlaceholder-alternatives branch December 29, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation m: image Something is referring to the image module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant