Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve variable naming of system module #3315

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Dec 3, 2024

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels Dec 3, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Dec 3, 2024
@ST-DDT ST-DDT requested review from a team December 3, 2024 10:32
@ST-DDT ST-DDT self-assigned this Dec 3, 2024
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 4794c0d
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/674ee3235209060008dc0349
😎 Deploy Preview https://deploy-preview-3315.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (ecb5cb4) to head (4794c0d).
Report is 3 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3315      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      217137   217137              
  Branches      985      978       -7     
==========================================
- Hits       217076   217066      -10     
- Misses         61       71      +10     
Files with missing lines Coverage Δ
src/modules/system/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team December 3, 2024 12:32
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't have a problem with the change suggested, I also did not have any problems with the previous source code. This to me feels like making a change for the sake of changing the codebase. I don't want to block so I'll still approve.

@ST-DDT ST-DDT added this pull request to the merge queue Dec 4, 2024
Merged via the queue into next with commit 2ba5edb Dec 4, 2024
26 checks passed
@ST-DDT ST-DDT deleted the coding-style/system branch December 4, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior m: system Something is referring to the system module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants