-
-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve variable naming of system module #3315
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3315 +/- ##
==========================================
- Coverage 99.97% 99.96% -0.01%
==========================================
Files 2806 2806
Lines 217137 217137
Branches 985 978 -7
==========================================
- Hits 217076 217066 -10
- Misses 61 71 +10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I don't have a problem with the change suggested, I also did not have any problems with the previous source code. This to me feels like making a change for the sake of changing the codebase. I don't want to block so I'll still approve.
Preparation for #2439
Related:
Improves the variable naming in the
system
module.Feel free to suggest better names.
This change is split from the no abbreviation lint PR, to reduce diff and I consider this slightly more valid than most of the other changes required for that.