Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): Add finance module for zh_CN #2370

Merged
merged 11 commits into from
Sep 17, 2023
Merged

feat(locale): Add finance module for zh_CN #2370

merged 11 commits into from
Sep 17, 2023

Conversation

CoolPlayLin
Copy link
Contributor

No description provided.

@CoolPlayLin CoolPlayLin requested a review from a team as a code owner September 1, 2023 14:52
@codecov
Copy link

codecov bot commented Sep 1, 2023 •
edited
Loading

Codecov Report

Merging #2370 (b25920c) into next (a7d25fa) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2370      +/-   ##
==========================================
- Coverage   99.61%   99.60%   -0.01%     
==========================================
  Files        2793     2800       +7     
  Lines      251586   252410     +824     
  Branches     1100     1094       -6     
==========================================
+ Hits       250610   251421     +811     
- Misses        949      962      +13     
  Partials       27       27
Files Changed Coverage Δ
src/locales/zh_CN/finance/account_type.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/finance/credit_card/index.ts 100.00% <100.00%> (ø)
...rc/locales/zh_CN/finance/credit_card/mastercard.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/finance/credit_card/visa.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/finance/currency.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/finance/index.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/finance/transaction_type.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: finance Something is referring to the finance module labels Sep 1, 2023
ST-DDT
ST-DDT previously approved these changes Sep 1, 2023
View reviewed changes
@ST-DDT ST-DDT requested review from a team September 1, 2023 21:04
ejcheng
ejcheng previously approved these changes Sep 4, 2023
View reviewed changes
@ejcheng ejcheng added the needs rebase There is a merge conflict label Sep 4, 2023
@ejcheng
Copy link
Member

ejcheng commented Sep 4, 2023

Hi, please rebase this pull request.

@CoolPlayLin CoolPlayLin dismissed stale reviews from ejcheng and ST-DDT via 278721b September 8, 2023 08:59
@CoolPlayLin CoolPlayLin removed their assignment Sep 8, 2023
@CoolPlayLin
Copy link
Contributor Author

done

@ST-DDT ST-DDT removed the needs rebase There is a merge conflict label Sep 8, 2023
ST-DDT
ST-DDT previously approved these changes Sep 8, 2023
View reviewed changes
@ST-DDT ST-DDT requested review from a team September 8, 2023 09:29
ejcheng
ejcheng previously approved these changes Sep 9, 2023
View reviewed changes
@CoolPlayLin CoolPlayLin dismissed stale reviews from ejcheng and ST-DDT via 10bb18a September 10, 2023 03:29
@CoolPlayLin CoolPlayLin mentioned this pull request Sep 16, 2023
Merged
@ST-DDT ST-DDT enabled auto-merge (squash) September 17, 2023 08:45
@ST-DDT ST-DDT disabled auto-merge September 17, 2023 08:45
@ST-DDT ST-DDT enabled auto-merge (squash) September 17, 2023 08:46
@ST-DDT ST-DDT merged commit aea4c9b into faker-js:next Sep 17, 2023
@CoolPlayLin CoolPlayLin deleted the New branch September 30, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@ejcheng ejcheng Awaiting requested review from ejcheng

Assignees
No one assigned
Labels
c: locale Permutes locale definitions m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
5 participants
@CoolPlayLin @ejcheng @matthewmayer @ST-DDT @Shinigami92