Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firstName is broken in en_GH (Ghana) #1552

Closed
9 of 10 tasks
matthewmayer opened this issue Nov 12, 2022 · 2 comments · Fixed by #1566
Closed
9 of 10 tasks

firstName is broken in en_GH (Ghana) #1552

matthewmayer opened this issue Nov 12, 2022 · 2 comments · Fixed by #1566
Assignees
Labels
c: bug Something isn't working c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone

Comments

@matthewmayer
Copy link
Contributor

Pre-Checks

Describe the bug

en_GH locale returns literal '{{person.female_first_name}}' or '{{person.male_first_name}}'

Minimal reproduction code

faker.setLocale("en_GH")
faker.person.firstName() //returns '{{person.female_first_name}}' or '{{person.male_first_name}}'

Additional Context

No response

Environment Info

System:
    OS: macOS 12.6
    CPU: (8) x64 Apple M1
    Memory: 44.64 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 14.20.0 - /usr/local/bin/node
    npm: 8.19.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 107.0.5304.110
    Firefox: 98.0
    Safari: 16.0

Which module system do you use?

  • CJS
  • ESM

Used Package Manager

npm

@matthewmayer matthewmayer added c: bug Something isn't working s: pending triage Pending Triage labels Nov 12, 2022
@wael-fadlallah
Copy link
Contributor

Hey, I can fix this one

@ejcheng ejcheng added c: locale Permutes locale definitions m: person Something is referring to the person module and removed s: pending triage Pending Triage labels Nov 12, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Nov 15, 2022

FYI: This file is broken and needs to be removed/fixed:

export default ['{{person.female_first_name}}', '{{person.male_first_name}}'];

@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug p: 1-normal Nothing urgent labels Nov 15, 2022
@ST-DDT ST-DDT moved this to Todo in Faker Roadmap Nov 15, 2022
@ST-DDT ST-DDT linked a pull request Nov 16, 2022 that will close this issue
Repository owner moved this from Todo to Done in Faker Roadmap Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants