refactor!: upgrade node minimum target #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
added
c: dependencies
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1494 +/- ##
==========================================
- Coverage 99.63% 99.63% -0.01%
==========================================
Files 2175 2165 -10
Lines 237613 237147 -466
Branches 1009 1021 +12
==========================================
- Hits 236751 236285 -466
Misses 841 841
Partials 21 21
|
Shinigami92
added
the
breaking change
ST-DDT
approved these changes
Oct 28, 2022
ejcheng
approved these changes
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://github.blog/changelog/2022-10-24-npm-v9-0-0-released/#%E2%9A%A0%EF%B8%8F-notable-breaking-changes (and
)
it is safe to upgrade the min target of node to these versions
This might (or might not 🤷) result in slightly optimized bundle outputs.
But as a positive side-effect we force folks to push their node and npm to secure versions.