From 35badc0892275c35818ca39800ec55d9c7342c8f Mon Sep 17 00:00:00 2001 From: Emilien Garreau Date: Fri, 26 May 2023 08:33:54 -0700 Subject: [PATCH] Fix inversion between fine and coarse implicit_functions Summary: Fine implicit function was called before the coarse implicit function. Reviewed By: shapovalov Differential Revision: D46224224 fbshipit-source-id: 6b1cc00cc823d3ea7a5b42774c9ec3b73a69edb5 --- pytorch3d/implicitron/models/overfit_model.py | 2 +- tests/implicitron/models/test_overfit_model.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pytorch3d/implicitron/models/overfit_model.py b/pytorch3d/implicitron/models/overfit_model.py index 52854d057..40ee5a1ba 100644 --- a/pytorch3d/implicitron/models/overfit_model.py +++ b/pytorch3d/implicitron/models/overfit_model.py @@ -373,7 +373,7 @@ def forward( self.implicit_function ] if self.coarse_implicit_function is not None: - implicit_functions += [self.coarse_implicit_function] + implicit_functions = [self.coarse_implicit_function, self.implicit_function] if self.global_encoder is not None: global_code = self.global_encoder( # pyre-fixme[29] diff --git a/tests/implicitron/models/test_overfit_model.py b/tests/implicitron/models/test_overfit_model.py index 15a6a6c64..8012e214c 100644 --- a/tests/implicitron/models/test_overfit_model.py +++ b/tests/implicitron/models/test_overfit_model.py @@ -109,9 +109,9 @@ def test_overfit_model_vs_generic_model_with_batch_size_one(self): # Adapt the mapping from generic model to overfit model mapping_om_from_gm = { - key.replace("_implicit_functions.0._fn", "implicit_function").replace( - "_implicit_functions.1._fn", "coarse_implicit_function" - ): val + key.replace( + "_implicit_functions.0._fn", "coarse_implicit_function" + ).replace("_implicit_functions.1._fn", "implicit_function"): val for key, val in generic_model.state_dict().items() } # Copy parameters from generic_model to overfit_model