Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomTypeTest.getCustomTypeNames often failed in CI test #9169

Closed
liujiayi771 opened this issue Mar 20, 2024 · 3 comments
Closed

CustomTypeTest.getCustomTypeNames often failed in CI test #9169

liujiayi771 opened this issue Mar 20, 2024 · 3 comments
Labels
bug Something isn't working triage Newly created issue that needs attention.

Comments

@liujiayi771
Copy link
Contributor

Bug description

Failed to allocateBytes 6.33MB: Exceeded memory allocator limit of 512.00MB, Source: RUNTIME, ErrorCode: MEM_ALLOC_ERROR
229: [       OK ] CustomTypeTest.customType (4 ms)
229: [ RUN      ] CustomTypeTest.getCustomTypeNames
229: /root/project/velox/expression/tests/CustomTypeTest.cpp:213: Failure
229: Expected equality of these values:
229:   (std::unordered_set<std::string>{ "JSON", "HYPERLOGLOG", "TIMESTAMP WITH TIME ZONE", })
229:     Which is: { "TIMESTAMP WITH TIME ZONE", "HYPERLOGLOG", "JSON" }
229:   names
229:     Which is: { "JSON", "MATERIALIZETESTUDT", "UDT2", "TIMESTAMP WITH TIME ZONE", "HYPERLOGLOG" }
229: [  FAILED  ] CustomTypeTest.getCustomTypeNames (0 ms)

System information

N/A

Relevant logs

No response

@liujiayi771 liujiayi771 added bug Something isn't working triage Newly created issue that needs attention. labels Mar 20, 2024
@liujiayi771
Copy link
Contributor Author

@mbasmanova I have found that MATERIALIZETESTUDT and UDT2 are registered in other tests. Is the failure of this UT related to the order of UT execution?

@mbasmanova
Copy link
Contributor

I have found that MATERIALIZETESTUDT and UDT2 are registered in other tests.

I'm not seeing these in Velox codebase. Are you running this test from a copy with custom changes?

Is the failure of this UT related to the order of UT execution?

It could be. Looks like some cleanup is missing somewhere.

@liujiayi771
Copy link
Contributor Author

ArrayViewTest and ArrayWriterTest register UDTs, which should be unregistered after use to avoid causing instability in the test results of CustomTypeTest.getCustomTypeNames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Newly created issue that needs attention.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants