-
Notifications
You must be signed in to change notification settings - Fork 2.6k
npm install fails #1137
Comments
Ran into same problem here. |
Edited my local /fbjs-scripts/gulp/check-dependencies.js L38 to
and changed package.json
was able to run the package.json scripts Was unable to run the webside folder project in Windows 10, "npm start" errored out. Got it working on |
cc @zpao can we increase node engine to 7.x ? |
My general feeling is that we should ensure we support building with LTS supported versions. If it doesn't work with LTS versions (eg 7.x, 8.x prior to last week), then we shouldn't go out of our way to support it. The other bit about code checking - that was fixed in a newer version of fbjs-scripts, along with some other things. So I recommend updating that as well. There's an immutable-related change. Not sure if it affects Draft, but should make sure everything is working post-update. tldr; sure, and add 8 as well. Also, update fbjs-scripts (read that changelog) |
Hi @zpao , I want to contribute to the project, however, I'm still having issues with the install process :(
Engines
Any help would be appreciated 👍 |
I can't repro on |
Thanks @mrkev that did the trick. I was able to build and submit a pull request to fix another issue :) |
Same issue. Used Yarn and that seemed to work. |
Thanks bro! |
[20:44:08] 'check-dependencies' errored after 5.32 s
[20:44:08] Error in plugin 'check-dependencies'
Message:
npm broke
[20:44:08] 'default' errored after 5.33 s
[20:44:08] Error in plugin 'run-sequence(check-dependencies)'
npm-debug.log.txt
The text was updated successfully, but these errors were encountered: