Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReviewStack] [Github] Missing metadata on Pull Requests for complete stack on ReviewStack #644

Open
equetzal opened this issue Jun 2, 2023 · 0 comments

Comments

@equetzal
Copy link

equetzal commented Jun 2, 2023

Context

When sending a stack of commits with the pr method to Github, the PRs usually have a bottom content like this:

Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/equetzal/huronOS-build-tools/pull/105).
* __->__ #105
* #104
* #103
* #102
* #101

That is usually rendered like this:

Stack created with Sapling. Best reviewed with ReviewStack.

Problem

When sending the commits as a PR to Github, only the last PR contains the full stack PRs link. (There is an example, if you check the bottom PR it does not have the links to the top PRs of the stack equetzal/huronOS-build-tools#105).

This data seems to be used by ReviewStack to display the stack switch dropbox options. But as the lower PRs miss the metadata, we're not being able to switch to PRs on top of the current reviewed PR:

PR ReviewStack PR Switch dropbox
From the top PR Captura de pantalla 2023-06-02 a la(s) 7 05 03 a m
From a middle PR Captura de pantalla 2023-06-02 a la(s) 7 05 30 a m
From the bottom PR Captura de pantalla 2023-06-02 a la(s) 7 05 43 a m

Expected behavior

I would expect sapling to update the previous PRs of the stack to include the full stack metadata so that ReviewStack is able to switch between lower and upper commits/PRs. (Like already happens with phabricator)

I know this feature might not be super easy to implement as users are able to change the PR descriptions, so this imply fetching the latest description, and append/replace the stack metadata for ReviewStack to read it.

@equetzal equetzal changed the title [ReviewStack] [Github] [SCM Push] Missing metadata on Pull Requests for complete stack on ReviewStack [ReviewStack] [Github] Missing metadata on Pull Requests for complete stack on ReviewStack Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants