Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline braces in JSX #2503

Merged

Conversation

anmonteiro
Copy link
Member

@anmonteiro anmonteiro commented Nov 30, 2019

This is a fix for the last regression reported by BuckleScript v7 that can be fixed in this repo.

The remaining one is a JSX PPX regression that doesn't live in this repo anymore.

fixes #2493
fixes #2502

@jordwalke
Copy link
Member

Looks good!

@anmonteiro anmonteiro merged commit 925f5b2 into reasonml:master Dec 1, 2019
@anmonteiro anmonteiro deleted the anmonteiro/inline-braces-in-jsx branch December 1, 2019 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regressions when upgrade in bucklescript 7 3.5.0: Strange reformatting of JSX props / labeled args
3 participants