OCaml 4.08 support #2426
Merged
OCaml 4.08 support #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
commented
Jun 15, 2019
src/reason-parser/reason_parser.mly
Outdated
| module Clflags = struct | ||
| include Clflags | ||
|
|
||
| let fast = unsafe |
There was a problem hiding this comment.
This is pretty annoying. It won't build in <4.08 so we might have to introduce yet another .cppo compat file
jordwalke
reviewed
Jun 16, 2019
| (rule | ||
| (targets lexer_warning.ml) | ||
| (deps ../generate/select.exe lexer_warning.ml-4.07 lexer_warning.ml-4.06 lexer_warning.ml-default) | ||
| (action (with-stdout-to %{targets} (run ../generate/select.exe lexer_warning.ml-4.07 lexer_warning.ml-4.06 lexer_warning.ml-default)))) | ||
| (deps ../generate/select.exe lexer_warning.ml-4.08 lexer_warning.ml-4.07 |
There was a problem hiding this comment.
Just for your information, select.ml is where we currently make similar compiler version specific decisions. That is an alternative to cppo. (It might not be as easy to do so for these particular special cases in this diff).
anmonteiro
force-pushed
the
anmonteiro/ocaml-4.08-support
branch
from
ea7890f to
927ab0e
Compare
jordwalke
approved these changes
Jul 4, 2019
|
Woohoo! Thanks as always. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Reason build on OCaml 4.08.
It depends on let-def/merlin-extend#9
The 4.08 CI steps are failing because of the above dependency. Perhaps we should vendor merlin-extend too as it's such a small dep?