Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep let not = ... #2197

Merged
merged 7 commits into from
Oct 2, 2018
Merged

keep let not = ... #2197

merged 7 commits into from
Oct 2, 2018

Conversation

anmonteiro
Copy link
Member

fixes #2169

@anmonteiro
Copy link
Member Author

anmonteiro commented Sep 21, 2018 •
edited
Loading

This now also fixes #2134 because OCaml versions prior to 4.06 (maybe 4.05?) can't parse let (foo [@attribute_here]) = ....

As such, we remove (only the) literal attributes before printing to either OCaml binary or to OCaml.

@anmonteiro
Copy link
Member Author

I think this is ready for a final look now.

@anmonteiro anmonteiro changed the title keep let not = ... and other OCaml <-> Reason swappable attributes keep let not = ... Sep 23, 2018
@IwanKaramazow IwanKaramazow self-requested a review September 23, 2018 12:17
IwanKaramazow
IwanKaramazow approved these changes Sep 23, 2018
View reviewed changes
Copy link
Contributor

@IwanKaramazow IwanKaramazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, approved

@chenglou chenglou merged commit 11ec3e8 into reasonml:master Oct 2, 2018
@anmonteiro anmonteiro deleted the anmonteiro/gh-2169 branch October 2, 2018 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IwanKaramazow IwanKaramazow IwanKaramazow approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[refmt] not -> (!)
4 participants
@anmonteiro @IwanKaramazow @chenglou @facebook-github-bot