Fix erroneous pattern parsing inside ternary expressions #2188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2155
The problem:
We "over"-parse spread operators inside patterns for better errors.
Because of the parens, semicolon
:
and...
now being a valid codepath, the lexer triggers an injection of anES6_FUN
token. This is clearly not an es6 style function expression.As soon as a
...
is reached with a closing}
, we know that we definitely don't have an es6 function expression. By exiting the lexer's es6-procedure at this stage, the parser continues it's normal behaviour and parses the correct expression.