Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rtop: make show directive work on remapped operators #2147

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

anmonteiro
Copy link
Member

@anmonteiro anmonteiro commented Aug 15, 2018

Fixes #1766

Since I was touching rtop in #2146, might as well fix this one too.

Before:

Reason # #show (^);
let ( ++ ): (string, string) => string;
Reason # #show (++);
Unknown element.
Reason # #toggle_syntax;
OCaml # #show (^);;
let ( ++ ): (string, string) => string;
OCaml # #show (++);;
Unknown element.
OCaml # #toggle_syntax;;
Reason # #show (++);
Unknown element.

After:

Reason # #show (^);
external ( ^ ): ref('a) => 'a = "%field0";
Reason # #show (++);
let ( ++ ): (string, string) => string;
Reason # #toggle_syntax;
OCaml # #show (^);;
val ( ^ ) : string -> string -> string
OCaml # #show (++);;
Unknown element.
OCaml # #toggle_syntax;;
Reason # #show (++);
let ( ++ ): (string, string) => string;

@jordwalke jordwalke merged commit 35fbcad into reasonml:master Aug 16, 2018
@anmonteiro anmonteiro deleted the anmonteiro/gh-1766 branch August 16, 2018 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rtop: show directive fails on remapped operators
3 participants