Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement correct printing for Ptyp_package as core_type. #2124

Merged
merged 2 commits into from
Aug 12, 2018

Conversation

IwanKaramazow
Copy link
Contributor

Fixes #2122

Also adds support for less parens in the context of a Ptyp_constr/Ptyp_tuple:

/* before */
type t = ref((module Console));

/* after */
type t = ref(module Console);

+ require less parens in `type t = ref(module Console)`
@hcarty
Copy link
Contributor

hcarty commented Aug 10, 2018

Does this cover record fields like type t = { m: (module M) }; too?

Thank you for working on this! I want to use Reason's master branch for the improved merlin support but this bug breaks a lot of code for me vs 3.2.0.

@IwanKaramazow
Copy link
Contributor Author

@hcarty added a test case, I'll update the PR to allow parsing without parens in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants