Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support non-parenthesized label colon type equal optional in type dec… #2058

Merged
merged 1 commit into from
Jul 11, 2018
Merged

support non-parenthesized label colon type equal optional in type dec… #2058

merged 1 commit into from
Jul 11, 2018

Conversation

anmonteiro
Copy link
Member

…larations

fixes #2056

@IwanKaramazow
Copy link
Contributor

Is it possible to also include the core_type without EQUAL optional type asd = ~a:bool => int; ?

@anmonteiro
Copy link
Member Author

I also wanted that but it resulted in conflicts 😢

@chenglou
Copy link
Member

Merging! Thanks

@chenglou chenglou merged commit 6cfddf9 into reasonml:master Jul 11, 2018
@anmonteiro anmonteiro deleted the gh-2056 branch July 11, 2018 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support type asd = ~a:bool=? => int;
4 participants
@anmonteiro @IwanKaramazow @chenglou @facebook-github-bot