Fix SHARPOP precedence #2050
Merged
Fix SHARPOP precedence #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A potential problem might be: $ echo 'foo#= bar[0]' | ./_build/install/default/bin/refmt -p ml
;;(foo #= bar).(0)I don't think this is right, but we can special case it in the lexer. |
|
Just fixed the issue pointed out in my last comment with the latest commit. |
src/reason-parser/reason_parser.mly
Outdated
| @@ -1209,6 +1209,7 @@ let package_type_of_module_type pmty = | |||
| %token SEMISEMI | |||
| %token SHARP | |||
| %token <string> SHARPOP | |||
| %token SHARPOP_WITH_EQUAL | |||
There was a problem hiding this comment.
can you rename this to SHARPEQUAL? SHARPOP_WITH_EQUAL conveys # with = , if you look at the other token names.
src/reason-parser/reason_lexer.mll
Outdated
| } | ||
| | "#" operator_chars+ | ||
| { SHARPOP(lexeme_operator lexbuf) } | ||
| { let l = lexeme_operator lexbuf in | ||
| if l = "#=" then |
There was a problem hiding this comment.
I wonder if we should add | "#=" { SHARPEQUAL } for clarity in the lexer. No hard opinions here.
There was a problem hiding this comment.
I think that's better too, will incorporate.
2 tasks
|
Just pushed the suggested changes. |
|
M-m-merged! |
anmonteiro
added a commit
to anmonteiro/reason
that referenced
this pull request
Jul 6, 2018
…ce, parens unnecessary on the right side
anmonteiro
added a commit
to anmonteiro/reason
that referenced
this pull request
Jul 6, 2018
…ce, parens unnecessary on the right side
anmonteiro
added a commit
to anmonteiro/reason
that referenced
this pull request
Jul 10, 2018
…ce, parens unnecessary on the right side
anmonteiro
added a commit
to anmonteiro/reason
that referenced
this pull request
Jul 22, 2018
…ce, parens unnecessary on the right side
anmonteiro
added a commit
to anmonteiro/reason
that referenced
this pull request
Aug 10, 2018
…ce, parens unnecessary on the right side
anmonteiro
added a commit
to anmonteiro/reason
that referenced
this pull request
Oct 2, 2018
…ce, parens unnecessary on the right side
anmonteiro
added a commit
to anmonteiro/reason
that referenced
this pull request
Oct 31, 2018
…ce, parens unnecessary on the right side
chenglou
pushed a commit
that referenced
this pull request
Nov 11, 2018
* Syntax sugar `["literal_string"]` for SHARPOPs `##` and `#=` * rebase on master after #2050, parse `#=` with higher precedence, parens unnecessary on the right side * array, string and bigarray get also get `#=` -> `=` * rebase on fast pipe fix * small refactor * Fix printer after rebase (caused by earlier refactor) * fix tests after rebase * Fixes after rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1507 #774
Not really sure how to write tests for this one.
I verified the following expressions manually: