Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse class exprs and types without trailing semicolon #2040

Merged
merged 2 commits into from
Jul 2, 2018
Merged

Parse class exprs and types without trailing semicolon #2040

merged 2 commits into from
Jul 2, 2018

Conversation

anmonteiro
Copy link
Member

fixes #2037

IwanKaramazow
IwanKaramazow reviewed Jul 1, 2018
View reviewed changes
Copy link
Contributor

@IwanKaramazow IwanKaramazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar looks ok, can we still print the trailing semi on the last row? We print them in let bindings too, it makes sense to be consistent here (I think).

@anmonteiro
Copy link
Member Author

Addressed.

@chenglou
Copy link
Member

chenglou commented Jul 2, 2018

Is this ready?

@anmonteiro
Copy link
Member Author

Yes sir

@chenglou
Copy link
Member

chenglou commented Jul 2, 2018

Thanks!

@chenglou chenglou merged commit 0b042d1 into reasonml:master Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IwanKaramazow IwanKaramazow IwanKaramazow left review comments

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Class expression doesn't parse without trailing semicolon
4 participants
@anmonteiro @chenglou @IwanKaramazow @facebook-github-bot