restore ocaml syntax printing in rtop #2031
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Except the one thing I pointed out, this whole thing looks good to me... @jordwalke what do you think? |
src/rtop/reason_utop.ml
Outdated
| @@ -67,7 +87,8 @@ let init_ocaml () = | |||
| UTop.parse_toplevel_phrase := UTop.parse_toplevel_phrase_default; | |||
| UTop.parse_use_file := UTop.parse_use_file_default; | |||
| UTop.history_file_name := | |||
| Some (Filename.concat LTerm_resources.home ".utop-history") | |||
| Some (Filename.concat LTerm_resources.home ".utop-history"); | |||
| restore_toploop_printing () | |||
There was a problem hiding this comment.
Is there any reason why restore_tooploop_printing needs to be a function? might as well just drop the printer wiring logic in here (like in init_reason)
matthiaskern
force-pushed
the
rtop-ocaml-printing
branch
from
3e902b8 to
f3fb2b0
Compare
|
Thanks! |
#toggle_syntaxnow also toggles printing to ocamlcc @ryyppy