allow whitespace before closing >
#2021
Conversation
src/reason-parser/reason_lexer.mll
Outdated
| @@ -538,9 +538,9 @@ rule token = parse | |||
| set_lexeme_length lexbuf 1; | |||
| LBRACE | |||
| } | |||
| | "</" uppercase_or_lowercase (identchar | '.') * ">" { | |||
| | "</" uppercase_or_lowercase (identchar | '.') * blank* ">" { | |||
There was a problem hiding this comment.
While we're add it, should we accept </ *space* div > too?
There was a problem hiding this comment.
Great point. Adding now
There was a problem hiding this comment.
@IwanKaramazow I'm actually not sure if that's possible given ></ is a valid infix operator.
There was a problem hiding this comment.
It's trivial to allow <div> </ div > (note the space between > and </, but <div></ div> would be really tricky, I think.
There was a problem hiding this comment.
Right, I see the problem, nevermind, this wouldn't benefit the quality of the code much.
There was a problem hiding this comment.
Alright, pushing the trivial case though because that one is easy.
| let buf = Lexing.lexeme lexbuf in | ||
| LESSSLASHIDENTGREATER (String.sub buf 2 (String.length buf - 2 - 1)) | ||
| LESSSLASHIDENTGREATER (String.trim (String.sub buf 2 (String.length buf - 2 - 1))) |
There was a problem hiding this comment.
Unrelated question: how many tries did it take you to get this right? This string api is the worst
There was a problem hiding this comment.
hahaha. I typed String. and searched for trim. Merlin helped me there, so 1 try!
There was a problem hiding this comment.
But the calculation, etc? String.sub throws so I'm always uneasy with off-by-ones
There was a problem hiding this comment.
The calculation was there already. I'm just trimming the result. What the calculation does is remove "</" and ">" from what we lexed. I'm trimming that result.
|
2fast4me |
fixes #2020