Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent printing of opening extension expressions. #1979

Merged
merged 1 commit into from
Jun 2, 2018

Conversation

IwanKaramazow
Copy link
Contributor

Fixes #1978

The open expr open Syntax in the example contains an extension as child expression.
This is a "sequency" expression and should not be formatted with the
open syntax sugar.

The following should be formatted as is:

let work = () => {
  open Syntax;
  let%bind name = x;
  name;
};

The `open` expr `open Syntax` contains an extension as child expression.
This is a "sequency" expression and should not be formatted with the
open syntax sugar.

The following should be formatted as is:

let work = () => {
  open Syntax;
  let%bind name = x;
  name;
};
@chenglou chenglou merged commit 7ade7ef into reasonml:master Jun 2, 2018
anmonteiro added a commit to anmonteiro/reason that referenced this pull request Aug 10, 2018
This fixes a regression introduced in reasonml#1979
chenglou pushed a commit that referenced this pull request Aug 11, 2018
* Fix local open printing for `bs.obj`

This fixes a regression introduced in #1979

* Print `X.({"a": 1})` as `X.{"a": 1}`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants