Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print comments correct in presence of extension points #1940

Merged
merged 2 commits into from
May 17, 2018
Merged

Print comments correct in presence of extension points #1940

merged 2 commits into from
May 17, 2018

Conversation

IwanKaramazow
Copy link
Contributor

Fixes #1938

@chenglou
Copy link
Member

Boy you're on fire. Again, I'll let you self review. Ping me when you're done.

@IwanKaramazow
Copy link
Contributor Author

Done 😄It’s low hanging fruit

chenglou
chenglou reviewed May 17, 2018
View reviewed changes
src/reason-parser/reason_pprint_ast.ml Outdated
let len = List.length l in
let fstLoc = (List.nth l 0).pvb_loc in
let fstLoc = match extension with
| Some ext when ext.pexp_loc.loc_ghost == false -> ext.pexp_loc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you deep pattern match this one? Probably slightly better than a when

@chenglou chenglou merged commit 9314283 into reasonml:master May 17, 2018
@hcarty
Copy link
Contributor

hcarty commented May 17, 2018

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenglou chenglou chenglou left review comments

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IwanKaramazow @chenglou @hcarty @facebook-github-bot