Fix printing & parsing of nested uncurried syntax. #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parses/prints `add(. 1, .2)` correct as `(add(. 1))(. 2)`
|
Still one case failing, need to fix the locations in parsing. |
cristianoc
reviewed
Feb 22, 2018
src/reason-parser/reason_parser.mly
Outdated
| let expr = if args = [] then body | ||
| else | ||
| let (args, wrap) = process_underscore_application args in | ||
| let expr = mkexp (Pexp_apply (body, args)) in |
There was a problem hiding this comment.
How about taking the location range from the arguments:
let args_loc = match args, List.rev args with
| ((_, s)::_), ((_, e)::_) -> mklocation s.pexp_loc.loc_start e.pexp_loc.loc_end
| _ -> assert false in
let expr = mkexp (Pexp_apply (body, args)) ~loc:args_loc in
There was a problem hiding this comment.
Thanks for the code, exactly what was needed.
The start & end location of the args form natural candidates for the location of the corresponding Pexp_apply.
|
M-M-MERGED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1823
Parses/prints
add(. 1, .2)correct as(add(. 1))(. 2)