Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow parsing of constraint expressions without parens inside constructor expr #1576

Merged
merged 3 commits into from
Oct 30, 2017
Merged

Allow parsing of constraint expressions without parens inside constructor expr #1576

merged 3 commits into from
Oct 30, 2017

Conversation

IwanKaramazow
Copy link
Contributor

@IwanKaramazow IwanKaramazow commented Oct 30, 2017 •
edited by chenglou
Loading

Fixes #1567

/* before */
Some((x: string), (y: int), (b: float));

/* after */
Some(x: string, y: int, b: float);

Parser didn't support the form without parens.

@chenglou
Copy link
Member

Rebasing after having merged #1560. Let's see if this works

@chenglou
Copy link
Member

Seems working. Merged!

@chenglou chenglou merged commit 9c88eba into reasonml:master Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IwanKaramazow @chenglou @facebook-github-bot