Print`foo(()) as` foo() + update parser #1560

IwanKaramazow · 2017-10-27T17:06:14Z

chenglou · 2017-10-30T21:18:23Z

src/reason_pprint_ast.ml

@@ -4702,6 +4702,10 @@ class printer  ()= object(self:'self)
  method constructor_expression ?(polyVariant=false) ~arityIsClear stdAttrs ctor eo =
    let (implicit_arity, arguments) =
      match eo.pexp_desc with
+      | Pexp_construct ( {txt= Lident "()"},_) ->
+          (* `foo() is a polymorphic variant that contains a single unit construct as expression


Great comment

chenglou · 2017-10-30T21:18:29Z

Thanks!

Print foo() + update parser

ef72d95

facebook-github-bot added the CLA Signed label Oct 27, 2017

chenglou reviewed Oct 30, 2017

View reviewed changes

chenglou merged commit f4ac62a into reasonml:master Oct 30, 2017

chenglou mentioned this pull request Oct 30, 2017

Allow parsing of constraint expressions without parens inside constructor expr #1576

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Print`foo(()) as` foo() + update parser #1560

Print`foo(()) as` foo() + update parser #1560

IwanKaramazow commented Oct 27, 2017 •

edited by chenglou

Loading

chenglou Oct 30, 2017

chenglou commented Oct 30, 2017

Printfoo(()) as foo() + update parser #1560

Printfoo(()) as foo() + update parser #1560

Conversation

IwanKaramazow commented Oct 27, 2017 • edited by chenglou Loading

chenglou Oct 30, 2017

Choose a reason for hiding this comment

chenglou commented Oct 30, 2017

Print`foo(()) as` foo() + update parser #1560

Print`foo(()) as` foo() + update parser #1560

IwanKaramazow commented Oct 27, 2017 •

edited by chenglou

Loading