[Flight Parcel] Implement findSourceMapURL #32294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
reviewed
Feb 4, 2025
| @@ -30,6 +30,17 @@ import type {TemporaryReferenceSet} from 'react-client/src/ReactFlightTemporaryR | |||
| export {createTemporaryReferenceSet} from 'react-client/src/ReactFlightTemporaryReferences'; | |||
| export type {TemporaryReferenceSet}; | |||
|
|
|||
| function findSourceMapURL(filename: string, environmentName: string) { | |||
| const devServer = parcelRequire.meta.devServer; | |||
There was a problem hiding this comment.
It's nice that this is totally encapsulated through an official API so the consumer doesn't have to do anything.
This was referenced Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
findSourceMapURLin react-server-dom-parcel, enabling source maps for replayed server errors on the client. It utilizes a new endpoint in the Parcel dev server that returns the source map for a given bundle/file. The error overlay UI has also been updated to handle these stacks. See parcel-bundler/parcel#10082Also updated the fixture to the latest Parcel canary. A few APIs have changed. We do have a higher level library wrapper now (
@parcel/rscadded in parcel-bundler/parcel#10074) but I left the fixture using the lower level APIs directly here since it is easier to see how react-server-dom-parcel is used.