Skip to content

Commit bfb3852

Browse files
troydemonbreunzpao
authored andcommitted
Fix for #7170 (#7486)
* Write failing test * Ensure .min and .max are set before .value * Adjusting test for false negative * Revert test adjustment (apparently it was only failing locally) (cherry picked from commit 3013afe)
1 parent df43561 commit bfb3852

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/renderers/dom/client/wrappers/ReactDOMInput.js

+4
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,10 @@ var ReactDOMInput = {
6767
// Make sure we set .step before .value (setting .value before .step
6868
// means .value is rounded on mount, based upon step precision)
6969
step: undefined,
70+
// Make sure we set .min & .max before .value (to ensure proper order
71+
// in corner cases such as min or max deriving from value, e.g. Issue #7170)
72+
min: undefined,
73+
max: undefined,
7074
}, DisabledInputUtils.getHostProps(inst, props), {
7175
defaultChecked: undefined,
7276
defaultValue: undefined,

src/renderers/dom/client/wrappers/__tests__/ReactDOMInput-test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -733,7 +733,7 @@ describe('ReactDOMInput', function() {
733733
);
734734
});
735735

736-
it('sets type and step before value always', function() {
736+
it('sets type, step, min, max before value always', function() {
737737
if (!ReactDOMFeatureFlags.useCreateElement) {
738738
return;
739739
}
@@ -760,10 +760,10 @@ describe('ReactDOMInput', function() {
760760
'set data-reactroot',
761761
'set type',
762762
'set step',
763-
'set value',
764763
'set min',
765764
'set max',
766765
'set value',
766+
'set value',
767767
'set checked',
768768
'set checked',
769769
]);

0 commit comments

Comments
 (0)