From 888b6ab2ba4192c20f9f76a6522b8adf4d840a42 Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Thu, 15 Jun 2023 06:35:59 -0700 Subject: [PATCH] Use `fileExists` in replace_hermes script (#37911) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/37911 Thanks to [adrianha](https://github.com/adrianha) for spotting a bug in the script that replace the Hermes engine. I miscopied the variable to check when there is no previous build file. This change uses the right variable and improves also the messages printed to the user. ## Changelog: [Internal] - Fix replace_hermes_version script using the right `fileExists` variable Reviewed By: dmytrorykun Differential Revision: D46762041 fbshipit-source-id: 8a0ed91349575e2b994613eb763f79e4318486ed --- .../sdks/hermes-engine/utils/replace_hermes_version.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/react-native/sdks/hermes-engine/utils/replace_hermes_version.js b/packages/react-native/sdks/hermes-engine/utils/replace_hermes_version.js index 1ccc91b85f9e79..ce1bb48f542bd8 100644 --- a/packages/react-native/sdks/hermes-engine/utils/replace_hermes_version.js +++ b/packages/react-native/sdks/hermes-engine/utils/replace_hermes_version.js @@ -34,15 +34,17 @@ function shouldReplaceHermesConfiguration(configuration) { console.log(`Found ${LAST_BUILD_FILENAME} file`); const oldConfiguration = fs.readFileSync(LAST_BUILD_FILENAME).toString(); if (oldConfiguration === configuration) { - console.log('No need to download a new build of Hermes!'); + console.log( + 'Same config of the previous build. No need to replace Hermes engine', + ); return false; } } // Assumption: if there is no stored last build, we assume that it was build for debug. - if (!fs.existsSync && configuration === 'Debug') { + if (!fileExists && configuration === 'Debug') { console.log( - 'File does not exists, but Debug configuration. No need to download a new build of Hermes!', + 'No previous build detected, but Debug Configuration. No need to replace Hermes engine', ); return false; }