From e91fe36fe1a6289062ce50d625994840ef546c01 Mon Sep 17 00:00:00 2001 From: Vojtech Novak Date: Sat, 26 Nov 2022 14:27:06 +0100 Subject: [PATCH 1/2] chore: RCTConvert - allocate array with capacity --- Libraries/TypeSafety/RCTConvertHelpers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Libraries/TypeSafety/RCTConvertHelpers.h b/Libraries/TypeSafety/RCTConvertHelpers.h index e7bd47bcbd26bf..fcd17a68a836d6 100644 --- a/Libraries/TypeSafety/RCTConvertHelpers.h +++ b/Libraries/TypeSafety/RCTConvertHelpers.h @@ -23,7 +23,7 @@ using LazyVector = FB::LazyVector; template NSArray *RCTConvertVecToArray(const ContainerT &vec, id (^convertor)(typename ContainerT::value_type element)) { - NSMutableArray *array = [NSMutableArray new]; + NSMutableArray *array = [[[NSMutableArray alloc] initWithCapacity:vec.size()]; for (size_t i = 0, size = vec.size(); i < size; ++i) { id object = convertor(vec[i]); array[i] = object ?: (id)kCFNull; From 5ff140a99b4f155aadbe46ce52119468acb6d953 Mon Sep 17 00:00:00 2001 From: Vojtech Novak Date: Sat, 26 Nov 2022 16:34:04 +0100 Subject: [PATCH 2/2] Update RCTConvertHelpers.h --- Libraries/TypeSafety/RCTConvertHelpers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Libraries/TypeSafety/RCTConvertHelpers.h b/Libraries/TypeSafety/RCTConvertHelpers.h index fcd17a68a836d6..d33f42c8ff18d8 100644 --- a/Libraries/TypeSafety/RCTConvertHelpers.h +++ b/Libraries/TypeSafety/RCTConvertHelpers.h @@ -23,7 +23,7 @@ using LazyVector = FB::LazyVector; template NSArray *RCTConvertVecToArray(const ContainerT &vec, id (^convertor)(typename ContainerT::value_type element)) { - NSMutableArray *array = [[[NSMutableArray alloc] initWithCapacity:vec.size()]; + NSMutableArray *array = [[NSMutableArray alloc] initWithCapacity:vec.size()]; for (size_t i = 0, size = vec.size(); i < size; ++i) { id object = convertor(vec[i]); array[i] = object ?: (id)kCFNull;