From 187fc09b9dc550d27f6798847c5f72a86260b97c Mon Sep 17 00:00:00 2001 From: Joshua Gross Date: Tue, 4 Aug 2020 17:03:28 -0700 Subject: [PATCH] Resolve crashes in NativeAnimated in Fabric Summary: Reduce crash volume. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D22934177 fbshipit-source-id: 5b959239a7c1cabe3b552e2b99b32c7735fe7bf8 --- .../facebook/react/animated/NativeAnimatedNodesManager.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/animated/NativeAnimatedNodesManager.java b/ReactAndroid/src/main/java/com/facebook/react/animated/NativeAnimatedNodesManager.java index dda6b1611dee3d..b02da661b611be 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/animated/NativeAnimatedNodesManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/animated/NativeAnimatedNodesManager.java @@ -719,6 +719,9 @@ private void updateNodes(List nodes) { + updatedNodesCount); if (mEventListenerInitializedForFabric && cyclesDetected == 0) { ReactSoftException.logSoftException(TAG, new ReactNoCrashSoftException(ex)); + } else if (mEventListenerInitializedForFabric) { + // Crashes in Debug, but not in Production + ReactSoftException.logSoftException(TAG, ex); } else { throw ex; }